The usage of std::binary_function is really old legacy to define the functions
used in STL algorithms like std::sort. std::binary_function was deprecated with
C++11 and removed from C++ with C++17. Obviously it is still supported by some
compilers since compilation errors only occured with newer Apple clang versions.

Switch to the modern implementation using lambdas in the STL algorithms.
This also increase code readability since the code is located at the same place
where it is used.

The change was confirmed to not introduce changes in the output by comparing
the produced TTrees before and after the commit in all produced ROOT files.

CA: Moving the cbm::algo::ca::EDetectorID definition in CbmDefs.h to unify the online/offline CA interfaces

CA: replacing the hard-coded disabling of detector subsystems with respect to the tracking mode (STS, mCBM, global) to the corresponding CA-configs; adding geometry layer index to ca::Station

[BugFix] Add [KfCore/CaCore/Algo]Offline libraries to remove feed down of NO_ROOT flag to libraries in reco folder

- Build AlgoOffline library only if not in CBM_ONLINE_STANDALONE (aka not online container mode)
- Build [Ca/Kf]CoreOffline libs only if not in CBM_ONLINE_STANDALONE (aka not online container mode)
- Use AlgoOffline as dep for libs CbmSimDigitizationSteer CbmAtConverterSteer CbmRecoOfflineSteer

Sergei Zharko authored 7 months ago and Sergei Zharko committed 7 months ago

  - a possibility of separating a full and active tracking station volumes
  - retrieving of active volume for TRD and TOF
  - changing the CbmTrackingDetectorInterfaceBase::kDebugGeoDefined{true} flag to CbmTrackingDetectorInterfaceBase::kLegacy{false}
    (if kLegacy == true, the old tracking station representation is used)

Sergei Zharko authored 7 months ago and Sergei Zharko committed 7 months ago

CbmStsStation: the z-reference field is replaced with the coordinates of the lower and upper bounds of a station

Sergei Zharko authored 7 months ago and Sergei Zharko committed 7 months ago

  - Replacement of property getters in derived classes with the station info structure filling at the interfaces initialization
  - Adding of geometry based TOF and TRD station property initialization (for now in a test mode with CbmTrackingDetectorInterfaceBase::kDebugGeoDefined = true)

Sergei Zharko authored 7 months ago and Sergei Zharko committed 7 months ago

  - Replacement of property getters in derived classes with the station info structure filling at the interfaces initialization
  - Adding of geometry based TOF and TRD station property initialization (for now in a test mode with CbmTrackingDetectorInterfaceBase::kDebugGeoDefined = true)

Sergei Zharko authored 9 months ago and Pierre-Alain Loizeau committed 7 months ago

- metadata structure for histograms (at the moment an extendable 8-bit word for control flag storage)
- transer of a timeslice index to the histogram server

histogram server:
- functionality of additional extended histograms storing vs different TS quantities (for example, TS index)

1. CbmPVFinderKFGlobal: fix of track access
2. reco_mcbm.sh: default parameter path for the online binary is ${VMCWORKDIR}/parameters/online (explicit pass is not required anymore)
3. mcbm_event_reco_L1.C optional PV-finder routine
4. CbmGlobalTrack.h: TODO is added

Sergei Zharko authored 10 months ago and Sergei Zharko committed 10 months ago

1) possibility for giving a supporting message to the checked criteria, if they are not passed
2) cleaning-up of the CA input QA

Sergei Zharko authored 10 months ago and Sergei Zharko committed 10 months ago

The functions InitDataBranches and InitHistograms are merged into the InitQa function,
the functions FillHistograms and InitTimeslice are merged into the ExecQa function.

Sergei Zharko authored 10 months ago and Sergei Zharko committed 10 months ago

The commit introduces the possibility of the specific QA task configuration withing the QA-config yaml file.
In the yaml-file, the configuration should be defined under qa/<task name>/specific node. On the task side
the configuration is represented with a plain structure (Config), which can be defined using the function
std::optional<Config> CbmQaTask::ReadSpecificConfig<Config>() in the task initialization function (for
expample see the CbmCaInputQaBase class implementation).

The specific configuration feature is optional and can rely on the default-initialized Config structure, so the "specific" branch
of the QA-configuration file is not mandatory.