Administrator authored 3 years ago and Sergey Gorbunov committed 3 years ago

It was found that switching form FairSoft jun19p2 to nov20 or apr21 has a
dramatic influence on the performance of the KFParticleFinder. The runtime
for on of the tests increased by roughly a factor 16.
https://redmine.cbm.gsi.de/issues/2220
After long investigations it turned out that the compilation flags for the
package were inherited from the ROOT and the CbmRoot project which switched
of the performance flag "-O" when using FairSoft nov20 or apr21.
The merge request fixes the issue by defining the CMAKE_BUILD_TYPE explicitely
to be RelWithDebugInfo.
The merge request also updates the VC version from 1.4.1 to 1.4.2. refs #2220

Dominik Smith authored 3 years ago and Dominik Smith committed 3 years ago

Implemented monitoring for CbmStsUnpackAlgoLegacy. Minor fix to CbmStsUnpackConfig and some cleanup of CbmStsUnpackAlgo and CbmStsUnpackAlgoBase.

Dominik Smith authored 3 years ago and Dominik Smith committed 3 years ago

Bugfix: Replaced ECbmModuleId::kHodo by ECbmModuleId::kT0 in CbmTaskBuildRawEvents and CbmEvbuildRawTask.

This update adds parameter files corresponding to the trd_v21a geometry
for the mCBM beamtine in June 2021.

Adrian A. Weber authored 3 years ago and Volker Friese committed 3 years ago

remove sorting from Algo and add check if time is greater 0. Mkissing backplanes in data could produce negative values and bee an issue. These digis are not stored

Administrator authored 3 years ago and Florian Uhlig committed 3 years ago

With macosx 10.13 (Apple clang 10.0) there is a runtime problem when
loading libL1. The problem is due to the usage of a static constexpr
in the source file which can be overcome when doing a static cast
of the variable.

Update TRD v21a by Alexandru and complete mCBM 2021_07 setup, update external/geometry tag, refs #2215

Before this fix only the number of digis of the last component of a subsystem endet up in the counter of the event header. Now an Add function is used and the counters a resetted at the beginning of each timeslice.

This adds a safeties that protect from unwanted behavior, in case of corrupted EOM messages.

The new version implements a workaround for CbmRoot. With the latest FairSoft
versions on macosx it comes otherwise to runtime errors when JIT compiling a
macro. The problem is a define statement in termios.h which defines B0 to be 0.
This coonflicts with the parameter B0 used in the header file.

Administrator authored 3 years ago and Florian Uhlig committed 3 years ago

There are some warnings which only show up on some systems and can't be
avoided. Filter them such that they don't show up on CDash.

These compiler warnings are only seen with clang on macosx.
Fix format in printf and Form functions.
Comment unused parameters.
Use correct C++ version when building the external flesnet project.

From FairRoot version v18.4.0 on the function CheckIfSensitive() of the class
FairModule is deprecated and replaced by the function IsSensitive(). The old
function is still available but usage results is a compilation error.
To be able to use FairRoot v18.2.1 and newer versions both functions are
implemented in the CbmRoot code where the old function simply forwards to the
new one. If there is no need to support older FairRoot versions the old
function can be simply removed from the source code.

Bug fix: Added missing break statement to loops in CbmAlgoBuildRawEvents::SetReferenceDetector() and CbmMcbm2019TimeWinEventBuilderAlgo::SetReferenceDetector().

Cornelius Feier-Riesen authored 3 years ago and Florian Uhlig committed 3 years ago

	modified:   analysis/PWGDIL/dielectron/lmvm/CbmAnaDielectronTaskDrawAll.cxx
	modified:   macro/analysis/dielectron/batch_job.py
	modified:   macro/analysis/dielectron/batch_send_common.py
	modified:   macro/analysis/dielectron/draw_all.py
	modified:   macro/analysis/dielectron/hadd_many.py
	modified:   macro/analysis/dielectron/run_analysis.C
	modified:   macro/analysis/dielectron/run_litqa.C
	modified:   macro/analysis/dielectron/run_reco.C

Set axes of several histograms to adaptive and adjusted ranges to account for new timing convention.

Pascal Raisig authored 3 years ago and Pierre-Alain Loizeau committed 3 years ago

In the data from mcbm2021 the possibility that the bits of the number of samples indicator in EOMs can be corrupted. This commit implements a safety which prevents the unpacker to go into a broken state in case of corrupted bits.