Dominik Smith authored 3 years ago and Florian Uhlig committed 3 years ago

CbmTrdHitProducerQa: Fetching TrdPoints and MC tracks from CbmMCDataManager instead of FairRootManager.

Dominik Smith authored 3 years ago and Florian Uhlig committed 3 years ago

- Histograms are now produced separately for residual and pull distributions.
- Enabled auto-extension of histogram axes.
- TrdPoint positions used are now mean of 'in' and 'out' values.
- Added residual and pull for hit times.
- Removed some root data types.

Dominik Smith authored 3 years ago and Florian Uhlig committed 3 years ago

CbmTrdHitProducerQa: Histograms are now produced for a pre-selected number of planes (set by user, default = 4). Added CbmQaCanvas containers for all histograms (layer-wise).

Since, the radiator is touched within the MR, we exchange its member appearances as raw pointer with smared shared pointers.
For backward compatibility with quite some amount of macros (quite some of them seem to be obsolete) forwarding constructors of CbmTrdDigitizer and CbmTrdQa have been implemented.

Alexandru Bercuci authored 3 years ago and Florian Uhlig committed 3 years ago

protect against missing par files
update steering macro for the new TRD-2D interface
incorporate parameter calibration into the FASP read-out data
protect the code for the case of par un-consistency (found e.g. for TRD-2Dh)
add user interface to the Asic param set
rename modules in the TRD setup
extend the TRD module type index above one digit
adding class definition to allow SPADIC info generation during unpacking

Administrator authored 3 years ago and Florian Uhlig committed 3 years ago

The wrong license headers currently block the merging of !470.

This adds a safeties that protect from unwanted behavior, in case of corrupted EOM messages.

Pascal Raisig authored 3 years ago and Pierre-Alain Loizeau committed 3 years ago

In the data from mcbm2021 the possibility that the bits of the number of samples indicator in EOMs can be corrupted. This commit implements a safety which prevents the unpacker to go into a broken state in case of corrupted bits.

Pascal Raisig authored 3 years ago and Florian Uhlig committed 3 years ago

This commit adds the measurement of the cpu and wall time to the unpacking algo template/CbmRecoUnpack::unpack function.
The values are printed add the end of the run and stored additionally in an output histogram.

Pascal Raisig authored 3 years ago and Pierre-Alain Loizeau committed 3 years ago

Unfortunately this does not yet produce digis, but I am note sure, if it is an parameter based issue or an issue with the implementation. I think it needs some experts from the Sts to have a look. Which is why I am pushing it.

Pascal Raisig authored 3 years ago and Pierre-Alain Loizeau committed 3 years ago

For the current situation with the TRD1D and TRD2D configs trying to create and access in principle the same "TrdDigi" branch a small workaround in the CbmRecoUnpack was required. Such that the first Config does not loose the correct pointer when the seconds overwrites the branch in the FairRootManager.

Pascal Raisig authored 3 years ago and Pierre-Alain Loizeau committed 3 years ago

Except for Psd the classes are empty dummies.

This is only required if one wants to implement direct instances based on the templates without derivation. But, in our case, were always derive it is unecessary and also causes issues. Hence, I removed it with this commit.

Pascal Raisig authored 3 years ago and Volker Friese committed 3 years ago

Integration of TRD unpacking, with empty implementations for unpacker, monitor container and parameter container.

Unify user names in the license header authors list.
Remove duplicate users in the authors list.
Cleanupo of some other inor issues.

Decision to not use doxygen for licence headers. Removes doxygen formatting and file tag.

Pulls some author and date information from previous headers, adds this to information from the svn and git repositories.
Inlude the standard copyright header to approximately 2000 files with institute of original committer as copyright holder.
Contributing authors from previous declaration and repository records.

Files with detected previous copyright or authorship skipped.
Copyright claimed for the current or last CBMC institute of the original commiter to the SVN or GIT repositories.
File distributed under GNU public license version 3.0 declared.

Revert "Adds license header to .cxx, .cpp, .h, and .C files"

This reverts commit 94da1500.

Removes one blank line

Revert "Removes one blank line"

This reverts commit a8e5e236.

Preemptive empty lines removal

If first two lines of a file are empty, or have spaces and tabs only then remove the lines.

Revert "Preemptive empty lines removal"

This reverts commit da38bf5d.

Add empty line

For stylistic reasons, an empty line is added after doxygen header.

Revert "Add empty line"

This reverts commit 30491934.

Puts space between includes.

Revert "Puts space between includes."

This reverts commit 468b7024.

Add multiple authors tag

Lists authors in order of their contribution

Revert "Add multiple authors tag"

This reverts commit f5d3e748.

Removes empty line on one file for clang format compliance.

Revert "Removes empty line on one file for clang format compliance."

This reverts commit fbac8bad.

Small changes as per requested.

Add small (o) to original commiters username.

Adds running 10 percent instead of line count treshold for contributors.

Revert "Small changes as per requested."

This reverts commit 84af7b5f.

Long form of names

Word originator beside original committer of file.

Revert "Long form of names"

This reverts commit 759426e2.

Add space between comma seperated double affilliation institutes

The latest version of our formating rules is applied to all header and source
files as well as to the macros using clang-format 11.0.

Fix a bug in the TRD cluster finder; the index of registering TRD hits to events was wrong, leading to one missing TRD hit. Refs #2112.

Pascal Raisig authored 3 years ago and Florian Uhlig committed 3 years ago

The hit counter was resetted for each event, while
the number of clusters correponds to the full timeslice.
Now the printed hitCounterTs counts all hits in a TS without a reset.
No explicit hit counting per event is currently implemented.

The class FairLogger is  meanwhile only a wrapper around the Logger class,
so use the Logger directly. This also helps to reduce many warnings when
using the Eclipse IDE.

iomanip was missing, somehow neither gcc on linux nor clangd cared for it.

In the processing routines for empty digi branches a situation could appear,
where nullptr were forwarded to unprotocted functions.
Now a protection against this situation and a safety against nullptr is implemented.

Add a setter to explicitly activate debug statements for TrdClusterFinder and HitProducer
The statements are printed with LOG(info)