add forgotten params for all intended FSD geometries
Necessary parameters for all the remaining FSD geometries that are to be merged into official repository. All are the same ideal digitization parameters, just like the one already merged here.
Merge request reports
Activity
Dear @f.uhlig, @p.-a.loizeau, @d.emschermann,
you have been identified as code owner of at least one file which was changed with this merge request.
Please check the changes and approve them or request changes.
added CodeOwners label
@e.clerkin I think this can quickly be merged, looks safe and lightweight enough to me. Should I take care of it and the corresponding "Cbmroot hashes" MR?
@l.chlad all (or most) corresponding geometries are anyway already in the geometry master and missing their parameters, is that right?
In general, looks okay to me to merge too, although the v23a and v23b geometries will not be merged to master. The v23a parameter file is already merged, so I guess we shouldn't make a distinction here.
To answer your question to @l.chlad, the geometries are not merged yet, but it is on my agenda today to review them.
@p.-a.loizeau Leave it to me to update the hashes as I will do it after I have merged the geometries.
added 5 commits
-
5ce6f72a...bda327ce - 4 commits from branch
CbmSoft:master
- 2166c817 - add forgotten params for all intended FSD geometries
-
5ce6f72a...bda327ce - 4 commits from branch
when updating the hashes please add the milestone OCT23 to the MR, otherwise I will loose track which changes must be ported to the release branch.