Add parameter files for TRD day-1 geometry
Add parameter files for the TRD Day-1 Geometry (v20b without grayed out modules in linked presentation) as requested in redmine issue https://redmine.cbm.gsi.de/issues/2888.
Merge request reports
Activity
Dear @a.bercuci, @p.kaehler,
you have been identified as code owner of at least one file which was changed with this merge request.
Please check the changes and approve them or request changes.
added CodeOwners label
- Resolved by Pierre-Alain Loizeau
@p.-a.loizeau Parameters matching for cbmroot_geometry!226 (merged)
assigned to @e.clerkin
This commit will need to be rebased locally. I can't do it from here for some reason.
Edited by Eoin Clerkinadded 5 commits
-
eac9efb5...142011a2 - 4 commits from branch
CbmSoft:master
- 89ca254c - Add parameter files for TRD day-1 geometry
-
eac9efb5...142011a2 - 4 commits from branch
added 3 commits
-
89ca254c...65514d20 - 2 commits from branch
CbmSoft:master
- 4151d87c - Add parameter files for TRD day-1 geometry
-
89ca254c...65514d20 - 2 commits from branch
@p.-a.loizeau could you check and rebase again such that @e.clerkin can merge? The corresponding geo is merged now already.
@e.clerkin after merging this we should prepare a Cbmroot MR bringing the hash updates of Geometry to
e9bc8730974a63f13dba56f9470bb36b8eaf387b
and parameter to whatever hash is assigned in the end to this commit. To be noted is that this Cbmroot MR will also bring the fixes to RICHv23a
.It will however need to wait for computing/cbmroot!1228 (merged) (TRD2D) to be merged, as this one brings an intermediate hash update and should not be interfered with (long and complicated MR that we are hopefully close to finally merge)
@p.-a.loizeau Please give a little more time to @p.subramani to respond to issue in https://redmine.cbm.gsi.de/issues/2759 before making MR for hash update of linked repos in cbmroot repo.
After discussing yesterday with @f.uhlig, I will try to take care of it today by doing some "admin black magic":
- Backup the RICH commits to another branch in the main geometry repo
- Remove them from the master of the geometry repo (leaving the TRD-Day1 commit as HEAD, admin only operation)
- Make an MR from the backup branch to the "new" master, which can be used later to re-introduce the RICH commits
- Merge the pending geometry MR cbmroot_geometry!228 (merged)
- Merge this MR to parameter
- Make an MR to the main Cbmroot repository bringing both hash updates: computing/cbmroot!1273 (merged)
Will edit this comment whenever I progress on it
Edited by Pierre-Alain Loizeauadded 3 commits
-
c37cbd2a...32c218ce - 2 commits from branch
CbmSoft:master
- 7c7a7c3d - Add parameter files for TRD day-1 geometry
-
c37cbd2a...32c218ce - 2 commits from branch