Removes bad material budget files
Removes bad material budget files. See redmine https://redmine.cbm.gsi.de/issues/2647
Merge request reports
Activity
Dear @v.singhal, @n.herrmann, @i.deppner, @a.bercuci, @p.kaehler,
you have been identified as code owner of at least one file which was changed with this merge request.
Please check the changes and approve them or request changes.
added CodeOwners label
assign @p.-a.loizeau
Suggest merging !113 (merged) first
Suggest removal of bad material budget maps, ie. this commit, before inclusion of fixed material budget files.
Edited by Eoin Clerkin@p.-a.loizeau please merge 2nd
Options are:
Either
merge !113 (merged) and then this !114 (merged)
Or
close !113 (merged) and squash the two commits on this MR !114 (merged)
Or
close !113 (merged) and accept the two commits on this MR !114 (merged) as is
I don't understand step 1 and step 2 meaning in this case and I think it is wrong.
Edited by Eoin Clerkincould this merge request be merged? I don't understand Eoins comment above.
added 7 commits
-
731ba1e0...0b60d321 - 6 commits from branch
CbmSoft:master
- 8f8034c1 - Removes bad material budget maps
-
731ba1e0...0b60d321 - 6 commits from branch
This was related to my renaming of the MRs, which I did just to make sure we merged in the proper order. I think as the other MR is already merged it should be OK.
One thing to know is that it may be that the hash for this MR cannot be updated in the main repo until the MR(s) bringing the new material maps are in (due to a simulation test for mCBM with the setup of 2021, I am not 100% sure if it is only in the weekly build or also in the CI one)
Edited by Pierre-Alain Loizeau