Skip to content
Snippets Groups Projects

Draft: Updated Version for CBM Much SIS-100 Geometry with multiple components...

Closed Apar Agarwal requested to merge (removed):master into master

Please insert x between square brackets to tick the boxes, add a meaningful description if the title is not enough and check the outcome with the "Preview" tab

In case you committed a new geometry:

  • Ran the scripts for materials and radiation length check on my new geometry file? (and read carefully the output of course)
    bash ci_scripts/check_radlen.sh <path>/<file>.geo.root
  • Added also the corresponding creation macro?
  • Checked that the geometry does not contains unexpected overlaps, e.g. either at end of the creation macro or with the something similar to the mCBM macro
    macro/mcbm/mcbm_check_overlaps.C

In case you committed a new setup file:

  • Checked that all geometries listed are present in the repository?
  • Ran the CBMROOT macro/geometry/check_media.C on the corresponding .geo.root file? (output by the transport macro)
Edited by Eoin Clerkin

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • assigned to @e.clerkin

  • Eoin Clerkin requested review from @e.clerkin

    requested review from @e.clerkin

  • Eoin Clerkin marked the checklist item Ran the scripts for materials and radiation length check on my new geometry file? (and read carefully the output of course) as completed

    marked the checklist item Ran the scripts for materials and radiation length check on my new geometry file? (and read carefully the output of course) as completed

  • Eoin Clerkin marked the checklist item Checked that all geometries listed are present in the repository? as completed

    marked the checklist item Checked that all geometries listed are present in the repository? as completed

  • Eoin Clerkin marked the checklist item Ran the CBMROOT macro/geometry/check_media.C on the corresponding .geo.root file? (output by the transport macro) as completed

    marked the checklist item Ran the CBMROOT macro/geometry/check_media.C on the corresponding .geo.root file? (output by the transport macro) as completed

  • Please rebase the branch to origin master.

    One comment, I notice that you use the master branch of your personal fork to push the MR, which makes rebasing more complicated.

    A few approaches to rebase, but I would probably reset commit back. Update master branch, then cherry-pick your desired change commit.

  • OK Let me try this once again

  • closed

Please register or sign in to reply
Loading