sets DEC21 geometries as defaults
Test setups for change of coordinate system are removed. Default APR21 setups are removed from repo. DEC21 setups as set as defaults.
Merge request reports
Activity
assigned to @f.uhlig
Dear @e.clerkin,
you have been identified as code owner of at least one file which was changed with this merge request.
Please check the changes and approve them or request changes.
added CodeOwners label
I will merge the MR after I finish my tests with the release candidate and the differnces between APR21 and the shifted APR21. Up to now I was only testing the sis100_electron setup and found today that the tof position correction wasn't yet ported to the release branch. I will now also compare the differences in the MCPoint distributions for the other setups and if those are okay I will merge.
mentioned in merge request computing/cbmroot!779 (merged)
@f.uhlig as far as I am concerned, this may be merged. Let me know if you see any issues.
- Resolved by Eoin Clerkin
if (strstr(setup, "_APR21")) targetZpos = 0.0; if (strstr(setup, "_DEC21")) targetZpos = -44.0; std::cout << "Target is at " << targetZpos << "cm from origin" << std::endl;
@e.clerkin @f.uhlig The target position is a property of the respective setup. In recent times, with varying target positions, I find it a bit clumsy to define the target z-positions in the transport macro, by grepping setup name strings. That is a possible weakness, where errors can be introduced.
Would it be possible to define the target again in the setup files, as it used to be the case in the past? That would be unambiguous.
- Resolved by Florian Uhlig
TString platGeoTag = "v13a";
@e.clerkin If you keep the MUCH / RICH support platform v13a, you are effectively shifting it downstream by 40 cm with the change of the coordinate system.
In all setups the position of the platform should be corrected accordingly for the coordinate system with origin in the center of the magnetic field.
mentioned in merge request !162 (merged)