Pierre-Alain Loizeau (99f62244) at 13 Nov 15:55
[TEMP] PAL test MQ macro last changes, for history
use template specialization for processing special digis (TRD(2D) ToF/T0)
Closing as now handled in computing/cbmroot!1000 (merged) (we got the round number with this one
Hi, This is old indeed. The commit here follows the idea from the CheckTiming which is in the master from quite some time. I guess it would be nice to update the MR and put it back on top of the master version. Thank you Alex
@a.bercuci Would I have understood right if I think that this MR would go around the problem that I fixed in a quick way in computing/cbmroot!993 (merged) ?
If yes, do you think it would be feasible/make sense to cherry-pick your 3 commits on top of a fresh branch of the main master and do a new MR to the main repository?
PS: Sorry for the grave-digging, I completely forgot about this MR until I stumbled on the WARNING message while debugging another CI test
Extend suggestions of PAL
Hi @p.-a.loizeau ,
OK. I will do as you suggested. The modifications are anyhow quite clustered. Have a further nice holiday Alex
Looks good from what I can understand
We decided while you were in holidays that after the 2022 beamtime "big merge" we would stop using the mCBM fork as intermediate merge point and instead work only with the main master (the fork remains to allow people to share testing code but does not have any official value anymore)
=> Could you please rebase your branch instead on the main master and do an MR there?
I will try to keep a look and maybe process it next week, but cannot promise anything as I went to France in holidays without my GSI laptop, so I have only AZERTY (fr-fr) keyboards and not all files at hand
Extend suggestions of PAL
Extend suggestions of PAL
Pierre-Alain Loizeau (dcede0f4) at 20 Jul 12:28
Pierre-Alain Loizeau (ec1ed70a) at 20 Jul 12:26
Pierre-Alain Loizeau (56e89940) at 20 Jul 12:25
Pierre-Alain Loizeau (a3a22735) at 20 Jul 12:25
Pierre-Alain Loizeau (a3a22735) at 20 Jul 12:25
[TEMP] PAL event building test macros, add per det max Digi Nb in h...
... and 178 more commits
Pierre-Alain Loizeau (cc0b5a19) at 20 Jul 12:09
Pierre-Alain Loizeau (cc0b5a19) at 20 Jul 12:09
Pierre-Alain Loizeau (cc0b5a19) at 20 Jul 12:09
Pierre-Alain Loizeau (cc0b5a19) at 20 Jul 12:09
Pierre-Alain Loizeau (cc0b5a19) at 20 Jul 12:09