1. 03 Dec, 2021 1 commit
    • Pierre-Alain Loizeau's avatar
      In STS unpacker, fix bug in handling of TS_MSB cycles happening at edge of MS + cleanup · 15c78e78
      Pierre-Alain Loizeau authored
      - Replace all legacy hard-coded numerical values for the TS_MSB cycle size by a constant derived in StsXyterMessage from the data format
      - Remove deprecated special cases in the handling of the TS_MSB messages which are not present anymore in the current CRI data format
      - Do not update TS_MSB and TS_MSB cycle from the MS header when the cycle happened exactly at the end of last MS
      - Recompute the TS+MSB in TS offset from the MS heder only when changing the Cycle or the TS_MSB from the same header
      - Add static method to convert Message Type into human readable string
      - Slight improve/cleanup of debug printouts and debug levels
      
      Was leading to errors and a crash in mCBM 2021 run 1588 files node8_3_0123 and node8_5_0002
      15c78e78
  2. 29 Nov, 2021 1 commit
  3. 25 Oct, 2021 2 commits
  4. 27 Sep, 2021 1 commit
    • Pierre-Alain Loizeau's avatar
      In STS unpack monitor, add plots and debug plots for raw stats and duplicate hits · 76cacd64
      Pierre-Alain Loizeau authored
      - FIX: collision of fMonitor declared on both CbmStsUnpackAlgoBase and CbmStsUnpackAlgo (was preventing monitor usage)
      - Make Debug mode of STS unpack monitor easier to control in the run_unpack_tsa.C macro
      - Main plot: Ratio of DIGI/RAW per FEB
      - Main plots: Share taken by each ch in each FEB for RAW, DIGIS and DUPLI
      - Main plot: Ratio of DIGI/RAW for each ch in each FEB
      - Main plot: Ratio of DUPLI/RAW for each ch in each FEB
      - Debug plot: ADC of DUPLI for each ch in each FEB
      - Debug plots: Evolution of Share taken by each ch in each FEB for RAW, DIGIS and DUPLI
      - Debug plot: Evolution of Ratio of DIGI/RAW for each ch in each FEB
      - Debug plot: Evolution of Ratio of DUPLI/RAW for each ch in each FEB
      - FIX: Warnings in some printout
      76cacd64
  5. 22 Sep, 2021 2 commits
    • Pierre-Alain Loizeau's avatar
      In STS unpackers, use only unsigned for time storage and add fatal where neg. could happen · 7292ef48
      Pierre-Alain Loizeau authored and Florian Uhlig's avatar Florian Uhlig committed
      Bug 2: In both Legacy and current unpackers, a signed integer was used at some point to store/return the raw timestamp in clock cycles.
      While the last bit would probably never be reached in standard usage, it could lead to negative values and crazy results during the
      conversion through double (full precision time in ns) and back to unsigned integer (ns precision time) for data coming from badly
      synchronized setups
      
      Bug 3: In the current unpacker, the subtraction of the Timeslice start time from the TS_MSB value was not protected against the case of
      badly synchronized data where the TS_MSb does not match the Timeslice index. It now triggers a Fatal as these data are not recoverable
      with this unpacker.
      7292ef48
    • Pierre-Alain Loizeau's avatar
      Fix the size of the TS MSB storage for the dupli filter · d7a2c588
      Pierre-Alain Loizeau authored and Florian Uhlig's avatar Florian Uhlig committed
      Bug 1: Size was too small which led to some digis with TS_MSB above 65555 escaping the duplicates filter.
      No effect on the digi themselves (time is computed from the original 64b/32b value).
      
      In the legacy case we can stay with 32b (instead of the original 64b or the old 16b) as the field in the
      raw message is 29b, while in the current version we need 64b to account for potential TS_MSB cycles and
      large Timeslice start offset.
      d7a2c588
  6. 21 Sep, 2021 1 commit
  7. 16 Sep, 2021 1 commit
    • Pierre-Alain Loizeau's avatar
      Fixes to the STS unpacking and CRI unpackers steering · 4bc7013a
      Pierre-Alain Loizeau authored and Volker Friese's avatar Volker Friese committed
      - Add Binning FW support to the Print method of the StsXyterMessage, enabled by default
      - Fix the duplicate digis filtering in the STS unpacker and make it flag controllable
      - Add an optional full time sorting to the Unpackers steering class
      - Related mCBM macros changes
      4bc7013a
  8. 06 Sep, 2021 2 commits
  9. 29 Jul, 2021 4 commits
  10. 22 Jul, 2021 9 commits