diff --git a/core/detectors/much/CbmMuchTrackingInterface.cxx b/core/detectors/much/CbmMuchTrackingInterface.cxx index 60a9f619843cab5050b30bf82cf5085eeeb27d28..0857f5f7b315f25b53b9ae59428d41c79f653c4f 100644 --- a/core/detectors/much/CbmMuchTrackingInterface.cxx +++ b/core/detectors/much/CbmMuchTrackingInterface.cxx @@ -17,11 +17,10 @@ ClassImp(CbmMuchTrackingInterface) - CbmMuchTrackingInterface* CbmMuchTrackingInterface::fpInstance = nullptr; - -// --------------------------------------------------------------------------------------------------------------------- -// -CbmMuchTrackingInterface::CbmMuchTrackingInterface() : FairTask("CbmMuchTrackingInterface") + // --------------------------------------------------------------------------------------------------------------------- + // + CbmMuchTrackingInterface::CbmMuchTrackingInterface() + : FairTask("CbmMuchTrackingInterface") { if (!fpInstance) { fpInstance = this; } } diff --git a/core/detectors/much/CbmMuchTrackingInterface.h b/core/detectors/much/CbmMuchTrackingInterface.h index a9d6163ae0285eefcf8c6dd2b4bedd7338e3a952..ae1d5a1d2d3306e7427fa31915d34a7f3f3df899 100644 --- a/core/detectors/much/CbmMuchTrackingInterface.h +++ b/core/detectors/much/CbmMuchTrackingInterface.h @@ -65,7 +65,7 @@ public: static CbmMuchTrackingInterface* Instance() { return fpInstance; } /// @brief Gets name of this subsystem - std::string GetDetectorName() const { return "MuCh"; } + std::string GetDetectorName() const override { return "MuCh"; } /// @brief Gets a tracking station of a CbmHit /// @param hit A pointer to CbmHit @@ -100,7 +100,7 @@ public: /// @return [phiU, phiV] - Stereo angles [rad] std::tuple<double, double> GetStereoAnglesSensor(int /*address*/) const override { - return std::tuple(0., TMath::Pi() / 2.); + return std::tuple(0., TMath::Pi() * 0.5); } /// @brief FairTask: sets parameter containers up @@ -120,13 +120,13 @@ public: /// @param stationId Index of the tracking station std::pair<int, int> ConvTrackingStationId2MuchId(int traStationId) const; - static CbmMuchTrackingInterface* fpInstance; ///< Instance of the class + inline static CbmMuchTrackingInterface* fpInstance{nullptr}; ///< Instance of the class CbmMuchGeoScheme* fGeoScheme {nullptr}; ///< MuCh geometry scheme instance std::vector<int> fFirstTrackingStation {}; - ClassDef(CbmMuchTrackingInterface, 0); + ClassDefOverride(CbmMuchTrackingInterface, 0); }; diff --git a/core/detectors/mvd/CbmMvdTrackingInterface.cxx b/core/detectors/mvd/CbmMvdTrackingInterface.cxx index 85898f50bdbb0cd8a0c72ca54e954e083ed8742d..94687e635a4fc838c61b18286e9139d50ccd9c0f 100644 --- a/core/detectors/mvd/CbmMvdTrackingInterface.cxx +++ b/core/detectors/mvd/CbmMvdTrackingInterface.cxx @@ -19,11 +19,10 @@ ClassImp(CbmMvdTrackingInterface) - CbmMvdTrackingInterface* CbmMvdTrackingInterface::fpInstance = nullptr; - -// --------------------------------------------------------------------------------------------------------------------- -// -CbmMvdTrackingInterface::CbmMvdTrackingInterface() : FairTask("CbmMvdTrackingInterface") + // --------------------------------------------------------------------------------------------------------------------- + // + CbmMvdTrackingInterface::CbmMvdTrackingInterface() + : FairTask("CbmMvdTrackingInterface") { if (!fpInstance) { fpInstance = this; } } diff --git a/core/detectors/mvd/CbmMvdTrackingInterface.h b/core/detectors/mvd/CbmMvdTrackingInterface.h index ec899d06a4773dc1986dfc46a571e460ffd00609..aa037c4c166c0b6352504ea3ec7114ee5a2e5a18 100644 --- a/core/detectors/mvd/CbmMvdTrackingInterface.h +++ b/core/detectors/mvd/CbmMvdTrackingInterface.h @@ -56,7 +56,7 @@ public: CbmMvdTrackingInterface& operator=(CbmMvdTrackingInterface&&) = delete; /// @brief Gets name of this subsystem - std::string GetDetectorName() const { return "MVD"; } + std::string GetDetectorName() const override { return "MVD"; } /// --- to be removed --- Gets the tracking station radiation length /// @param stationId Tracking station ID in the setup (NOTE: must be in range [0..GetNstations()-1]) @@ -116,7 +116,7 @@ public: /// @brief Check if the detector provides time measurements /// @param stationId Tracking station ID in the setup (NOTE: must be in range [0..GetNstations()-1]) /// @return Flag: true - station provides time measurements, false - station does not provide time measurements - bool IsTimeInfoProvided(int /*stationId*/) const { return true; } + bool IsTimeInfoProvided(int /*stationId*/) const override { return true; } /// @brief FairTask: ReInit method InitStatus ReInit() override; @@ -125,11 +125,11 @@ public: void SetParContainers() override; private: - static CbmMvdTrackingInterface* fpInstance; ///< Instance of the class + inline static CbmMvdTrackingInterface* fpInstance{nullptr}; ///< Instance of the class const CbmMvdStationPar* fMvdStationPar {nullptr}; ///< Pointer to the Mvd station parameters - ClassDef(CbmMvdTrackingInterface, 0); + ClassDefOverride(CbmMvdTrackingInterface, 0); }; #endif // CbmMvdTrackingInterface diff --git a/core/detectors/sts/CbmStsTrackingInterface.cxx b/core/detectors/sts/CbmStsTrackingInterface.cxx index e3c9533a350da370ef3204e3ba575c3bea377576..2eb761ccc11bc02fbcc97ff39736382d1a797ebd 100644 --- a/core/detectors/sts/CbmStsTrackingInterface.cxx +++ b/core/detectors/sts/CbmStsTrackingInterface.cxx @@ -19,11 +19,10 @@ ClassImp(CbmStsTrackingInterface) - CbmStsTrackingInterface* CbmStsTrackingInterface::fpInstance = nullptr; - -// --------------------------------------------------------------------------------------------------------------------- -// -CbmStsTrackingInterface::CbmStsTrackingInterface() : FairTask("CbmStsTrackingInterface") + // --------------------------------------------------------------------------------------------------------------------- + // + CbmStsTrackingInterface::CbmStsTrackingInterface() + : FairTask("CbmStsTrackingInterface") { if (!fpInstance) { fpInstance = this; } } diff --git a/core/detectors/sts/CbmStsTrackingInterface.h b/core/detectors/sts/CbmStsTrackingInterface.h index c1a4ae8222b59ebd2a516b5f8c2dfc441ee312b9..ce745604be01fb1c26105b4ba8f13e9bcf81c852 100644 --- a/core/detectors/sts/CbmStsTrackingInterface.h +++ b/core/detectors/sts/CbmStsTrackingInterface.h @@ -116,13 +116,13 @@ public: return CbmStsSetup::Instance()->GetStation(stationId); } - static CbmStsTrackingInterface* fpInstance; + inline static CbmStsTrackingInterface* fpInstance{nullptr}; - CbmStsParSetSensor* fStsParSetSensor {nullptr}; ///< - CbmStsParSetSensorCond* fStsParSetSensorCond {nullptr}; ///< - CbmStsParSetModule* fStsParSetModule {nullptr}; ///< + CbmStsParSetSensor* fStsParSetSensor{nullptr}; ///< + CbmStsParSetSensorCond* fStsParSetSensorCond{nullptr}; ///< + CbmStsParSetModule* fStsParSetModule{nullptr}; ///< - ClassDef(CbmStsTrackingInterface, 0); + ClassDefOverride(CbmStsTrackingInterface, 0); }; #endif // CbmStsTrackingInterface diff --git a/core/detectors/tof/CbmTofTrackingInterface.cxx b/core/detectors/tof/CbmTofTrackingInterface.cxx index ecc9928db26d3be60435d5f219e8e2dfef8735dc..b0d05509735e8dfe9e055e754174bf21dd7cffda 100644 --- a/core/detectors/tof/CbmTofTrackingInterface.cxx +++ b/core/detectors/tof/CbmTofTrackingInterface.cxx @@ -22,11 +22,10 @@ ClassImp(CbmTofTrackingInterface) - CbmTofTrackingInterface* CbmTofTrackingInterface::fpInstance = nullptr; - -// --------------------------------------------------------------------------------------------------------------------- -// -CbmTofTrackingInterface::CbmTofTrackingInterface() : FairTask("CbmTofTrackingInterface") + // --------------------------------------------------------------------------------------------------------------------- + // + CbmTofTrackingInterface::CbmTofTrackingInterface() + : FairTask("CbmTofTrackingInterface") { if (!fpInstance) { fpInstance = this; diff --git a/core/detectors/tof/CbmTofTrackingInterface.h b/core/detectors/tof/CbmTofTrackingInterface.h index cc970114be2a9a5bb757f5139e9927398ee51538..bb2ba3e3494d026ac647f7e94ceaa9586bff6223 100644 --- a/core/detectors/tof/CbmTofTrackingInterface.h +++ b/core/detectors/tof/CbmTofTrackingInterface.h @@ -51,7 +51,7 @@ class CbmTofTrackingInterface : public FairTask, public CbmTrackingDetectorInter CbmTofTrackingInterface& operator=(CbmTofTrackingInterface&&) = delete; /// @brief Gets name of this subsystem - std::string GetDetectorName() const { return "TOF"; } + std::string GetDetectorName() const override { return "TOF"; } /// @brief Gets stereo angles of the two independent measured coordinates /// @note The tracking does not use this method. It is only used by the QA task. @@ -59,7 +59,7 @@ class CbmTofTrackingInterface : public FairTask, public CbmTrackingDetectorInter /// @return [phiU, phiV] - Stereo angles [rad] std::tuple<double, double> GetStereoAnglesSensor(int /*address*/) const override { - return std::tuple(0., TMath::Pi() / 2.); + return std::tuple(0., TMath::Pi() * 0.5); } /// @brief Gets a tracking station of a ToF hit @@ -113,7 +113,7 @@ class CbmTofTrackingInterface : public FairTask, public CbmTrackingDetectorInter void SetParContainers() override; private: - static CbmTofTrackingInterface* fpInstance; ///< Instance of the class + inline static CbmTofTrackingInterface* fpInstance{nullptr}; ///< Instance of the class CbmTofDigiPar* fDigiPar{nullptr}; CbmTofDigiBdfPar* fDigiBdfPar{nullptr}; @@ -122,7 +122,7 @@ class CbmTofTrackingInterface : public FairTask, public CbmTrackingDetectorInter std::vector<double> fTofStationZMin{}; ///< Lower bounds of TOF stations along z-axis [cm] std::vector<double> fTofStationZMax{}; ///< Upper bounds of TOF stations along z-axis [cm] - ClassDef(CbmTofTrackingInterface, 0); + ClassDefOverride(CbmTofTrackingInterface, 0); }; #endif // CbmTofTrackingInterface diff --git a/core/detectors/trd/CbmTrdTrackingInterface.cxx b/core/detectors/trd/CbmTrdTrackingInterface.cxx index 8369859c83b64b426f417c99180385086e6dd02b..59b36523238f10a172a89c7ef74c9b5bb97e3094 100644 --- a/core/detectors/trd/CbmTrdTrackingInterface.cxx +++ b/core/detectors/trd/CbmTrdTrackingInterface.cxx @@ -23,11 +23,10 @@ ClassImp(CbmTrdTrackingInterface) - CbmTrdTrackingInterface* CbmTrdTrackingInterface::fpInstance = nullptr; - -// --------------------------------------------------------------------------------------------------------------------- -// -CbmTrdTrackingInterface::CbmTrdTrackingInterface() : FairTask("CbmTrdTrackingInterface") + // --------------------------------------------------------------------------------------------------------------------- + // + CbmTrdTrackingInterface::CbmTrdTrackingInterface() + : FairTask("CbmTrdTrackingInterface") { if (!fpInstance) { fpInstance = this; } } diff --git a/core/detectors/trd/CbmTrdTrackingInterface.h b/core/detectors/trd/CbmTrdTrackingInterface.h index 16ee4d943f967484bcad02eb7c0570cf240390e3..2d0e600c37d62ae643229b9aaee0184014c52fc7 100644 --- a/core/detectors/trd/CbmTrdTrackingInterface.h +++ b/core/detectors/trd/CbmTrdTrackingInterface.h @@ -107,12 +107,12 @@ class CbmTrdTrackingInterface : public FairTask, public CbmTrackingDetectorInter return static_cast<CbmTrdParModDigi*>(fTrdDigiPar->GetModulePar(fTrdDigiPar->GetModuleId(moduleId))); } - static CbmTrdTrackingInterface* fpInstance; ///< Instance of the class + inline static CbmTrdTrackingInterface* fpInstance{nullptr}; ///< Instance of the class CbmTrdParSetDigi* fTrdDigiPar{nullptr}; //CbmTrdParModDigi* fTrdModuleInfo {nullptr}; - ClassDef(CbmTrdTrackingInterface, 0); + ClassDefOverride(CbmTrdTrackingInterface, 0); }; #endif // CbmTrdTrackingInterface